refactor: centralize tracked item projection#226
Draft
mariusvniekerk wants to merge 2 commits intomainfrom
Draft
refactor: centralize tracked item projection#226mariusvniekerk wants to merge 2 commits intomainfrom
mariusvniekerk wants to merge 2 commits intomainfrom
Conversation
PR and issue handlers were each rebuilding the same response rules: repo decoration, detail-loaded flags, UTC detail timestamps, empty timeline slices, worktree links, and workspace refs. Moving those rules behind a tracked item projection module gives the API layer one place to preserve ADR 0001 timestamp behavior and makes handler call sites smaller and more uniform. The result is a deeper module seam: handlers fetch domain rows and pass them to projection helpers, while tests can exercise response-shape invariants directly without walking every route path. Verified with: go test ./internal/server -run 'TestProject|TestAPIGetPull|TestAPIListPulls|TestAPIGetIssue|TestAPIListIssues|TestAPISyncPR|TestAPISyncIssue' -shuffle=on; git diff --check Co-authored-by: OpenAI Codex <noreply@openai.com>
roborev: Combined Review (
|
Roborev flagged that the projection helper was covered mostly at the unit boundary even though list/detail handlers now depend on it. Add generated-client API tests over the real SQLite test server for PR and issue response shapes, including repo decoration, UTC detail timestamps, empty event/link slices, worktree links, and workspace refs. Validation: go test ./internal/server -run 'TestAPI(PullListAndDetailProjectSharedResponseShape|IssueListAndDetailProjectSharedResponseShape)$' -shuffle=on; git diff --check. Co-authored-by: OpenAI Codex <noreply@openai.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation: