Centralize routed item builders#229
Open
mariusvniekerk wants to merge 2 commits intomainfrom
Open
Conversation
roborev: Combined Review (
|
roborev: Combined Review (
|
PR and issue routes were split across the browser router, sidebar lists, focus views, and repository cards, which made each caller repeat the same owner/name/number/platformHost shape and URL encoding rules. Centralizing those refs and builders in the UI package gives routed item identity one home while keeping the frontend router focused on adapting browser location state. This deepens the route item module so new PR, issue, files, and focus callers can import the same named contracts instead of recreating URL strings locally. That improves locality and keeps issue platform host query handling uniform across list, focus, drawer, and repo-summary flows. Validation: bun run --cwd frontend typecheck; bun run --cwd packages/ui typecheck; bun run --cwd frontend test -- routes.test.ts router.test.ts router.initialization.test.ts activitySelection.test.ts RepoSummaryPage.test.ts; bun run --cwd frontend lint; bun run --cwd packages/ui lint; git diff --check. Co-authored-by: OpenAI Codex <noreply@openai.com>
Add full-stack e2e coverage for PR, issue, and focus routes so the shared route builders keep platform_host and API detail requests aligned.
mariusvniekerk
force-pushed
the
architecture-route-items
branch
from
5f79435 to
e1396e8
Compare
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How this makes the code better