feat: add middleman favicon

[mariusvniekerk]

• add a favicon for middleman using the approved review-hub mark
• wire the app shell to serve SVG and PNG favicon assets in browser tabs
• add a focused frontend test covering the favicon files and head links

[roborev-ci]

roborev: Combined Review (c5f6c34)

Code is clean; no Medium, High, or Critical findings.

All reported findings were below the requested severity threshold, and the other reviews found no issues.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (a7fced8)

Verdict: No Medium, High, or Critical issues found.

The reviewed changes appear clean. One agent noted a low-severity test file extension consistency issue in frontend/src/lib/favicon.test.js, but there were no findings at Medium severity or above.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[cpcloud]

I'm down with the favicon minus that gray snake looking thing on the bottom left 🤣

[mariusvniekerk]

yeah the gray snake thing is supposed to be a merge arrow, but codex is kinda shit at graphic design.

[roborev-ci]

roborev: Combined Review (ea184c7)

No Medium, High, or Critical findings were reported.

All agents agree the code is clean for reportable issues.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (15a27f3)

Medium issue found: the favicon arrow stem may not render; low-severity findings omitted.

Medium

• frontend/public/favicon.svg:9 — The arrow path uses a zero-width vertical segment (M26 26v10) and is styled only with fill, so the stem has no visible area when rendered. Add width to the stem geometry, such as a rectangle or polygon, or apply a stroke to the path.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (0ea794d)

No Medium, High, or Critical issues found.

All reported findings were either clean reviews or below the requested severity threshold.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[mariusvniekerk]

Think i prefer this variant

[cpcloud]

same

[roborev-ci]

roborev: Combined Review (4a96806)

Verdict: Changes look mostly sound, but runtime favicon integration is still insufficiently tested.

Medium

• Runtime build/serve path is not covered by the new tests
  Location: frontend/src/lib/favicon.test.js, frontend/index.html
  Problem: The added tests only validate source files on disk and hard-coded SVG path data. They do not exercise the actual production path: Vite copying public/ assets into dist, the app shell emitting the favicon links, and the embedded Go server serving those files. A build or serve integration regression would still pass.
  Fix: Add an end-to-end test that loads the app shell through the real HTTP server, verifies the favicon links are present, and confirms /favicon.svg and /favicon-32.png are served successfully.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[roborev-ci]

roborev: Combined Review (01e9fc9)

Code review verdict: no Medium, High, or Critical issues found.

No review findings met the reporting threshold. Security review also found no issues.

---

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

[cpcloud]

The mirror ones are nice, I kind of want maybe a green/red +/- thing in the middle maybe?

[mariusvniekerk]

lemme clank