Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR makes RDKit a required dependency and changes the default behavior of the buy function to canonicalize SMILES by default. This is a breaking change that bumps the version to 3.0.0.
- Makes RDKit a required dependency instead of optional
- Changes
buyfunction default to canonicalize SMILES (canonicalize=True) - Updates version to 3.0.0 across all relevant files
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup.py | Adds rdkit as a required dependency |
| molbloom/version.py | Updates version to 3.0.0 |
| molbloom/bloom/bloom.h | Updates C header version constant to 3.0.0 |
| molbloom/init.py | Changes buy function default canonicalize parameter to True |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Jgmedina95
approved these changes
Aug 18, 2025
Collaborator
There was a problem hiding this comment.
now that rdkit is a dependency, it would make sense to add it a the top of the file, for best practices rather than locally, for the canon function. Other than that, everything seems fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's almost always that case that you should canonicalize. Now that rdkit is on
pypi, let's just make it default. Breaking change because nowbuywill default canonicalize and there are now dependencies.Should address #31