Skip to content

Require rdkit and default canonicalize in buy#36

Merged
whitead merged 4 commits intomainfrom
default-canon
Aug 19, 2025
Merged

Require rdkit and default canonicalize in buy#36
whitead merged 4 commits intomainfrom
default-canon

Conversation

@whitead
Copy link
Copy Markdown
Owner

@whitead whitead commented Aug 18, 2025

It's almost always that case that you should canonicalize. Now that rdkit is on pypi, let's just make it default. Breaking change because now buy will default canonicalize and there are now dependencies.

Should address #31

@whitead whitead requested a review from Copilot August 18, 2025 02:08
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes RDKit a required dependency and changes the default behavior of the buy function to canonicalize SMILES by default. This is a breaking change that bumps the version to 3.0.0.

  • Makes RDKit a required dependency instead of optional
  • Changes buy function default to canonicalize SMILES (canonicalize=True)
  • Updates version to 3.0.0 across all relevant files

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
setup.py Adds rdkit as a required dependency
molbloom/version.py Updates version to 3.0.0
molbloom/bloom/bloom.h Updates C header version constant to 3.0.0
molbloom/init.py Changes buy function default canonicalize parameter to True

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@whitead whitead requested a review from Jgmedina95 August 18, 2025 02:08
Comment thread molbloom/__init__.py
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that rdkit is a dependency, it would make sense to add it a the top of the file, for best practices rather than locally, for the canon function. Other than that, everything seems fine.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call - thanks

@whitead whitead merged commit 8d34863 into main Aug 19, 2025
3 checks passed
@whitead whitead deleted the default-canon branch August 19, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants