feat: ignore elements with a vite-ignore or wxt-ignore attribute#1603
Merged
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aklinker1
approved these changes
Apr 24, 2025
Member
aklinker1
left a comment
There was a problem hiding this comment.
I saw your message in discord, your PRs are great! Thanks for splitting them up.
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Contributor
|
Thanks for helping make WXT better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the ability for the user to use ignore attributes, either
vite-ignoreorwxt-ignorein html elements to make wxt ignore those elements and not process the src or href attributes.If
wxt-ignoreis used as attribute, the attribute is removed. Thevite-ignoreattribute does not need to be removed as it is removed later by Vite.Manual Testing
Add the attribute
vite-ignoreorwxt-ignoreto alinkelement in an entrypoint html file. Thehrefattribute should not be processed in the resulting html file and thevite-ignoreorwxt-ignoreshould be removed.Related Issue
N/A.
Manually ignoring elements may be beneficial in some specific edge cases like in the problem which was discussed here: #1548