Use studio-display-control 0.2.1 for Studio Display XDR support#1230
Open
oskarn97 wants to merge 2 commits into
Open
Use studio-display-control 0.2.1 for Studio Display XDR support#1230oskarn97 wants to merge 2 commits into
oskarn97 wants to merge 2 commits into
Conversation
Vendor the Apple Studio Display USB control path into Twinkle Tray so the new Studio Display XDR can be detected and controlled without waiting on an external package update. Label Apple Studio Display and Studio Display XDR devices correctly while keeping the monitor integration isolated in a local helper module.
Switch Twinkle Tray back to the published Studio Display package now that XDR support and model metadata are available in 0.2.1. Keep the Twinkle Tray change set minimal by only updating the dependency and using getModelName() for the display label.
oskarn97
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
studio-display-controlfrom0.2.0to0.2.1to pick up the published Studio Display XDR supportdisplay.getModelName()so mixed Apple Studio Display and Studio Display XDR setups show the correct label in Twinkle TrayTest plan
npm cinpm run parcel-buildnpm exec electron-builder -- --dir --x64 --config.win.signAndEditExecutable=false