Skip to content
This repository was archived by the owner on May 20, 2022. It is now read-only.

Use patchsets file#9

Open
toy wants to merge 3 commits into
xing:masterfrom
toy:use-patchsets-file
Open

Use patchsets file#9
toy wants to merge 3 commits into
xing:masterfrom
toy:use-patchsets-file

Conversation

@toy
Copy link
Copy Markdown
Contributor

@toy toy commented Jan 13, 2022

Resolve problem described in #7 (comment)

@toy
Copy link
Copy Markdown
Contributor Author

toy commented Jan 13, 2022

Only after creating I see #8

@nevesenin
Copy link
Copy Markdown

Only after creating I see #8

😆 I don't mind. Could have also happen to me. I'm happy with any of this.

@toy
Copy link
Copy Markdown
Contributor Author

toy commented Jan 29, 2022

@skaes Can you please have a look?

@skaes
Copy link
Copy Markdown
Contributor

skaes commented Jan 30, 2022

@toy I'm not using rbenv, so I really don't want to test this or say it works. Someone who's using rbenv should test this.

@nevesenin
Copy link
Copy Markdown

Installed 2.6.1, 2.7.0, 2.7.4, 3.0.1 and 3.1.0. Worked as expected. All/only patches from the patchfile have been applied.

@nevesenin
Copy link
Copy Markdown

Moin @toy! I discovered, that the update script creates build files, that do not work with rubies with patchlevel because there is another subdirectory for each patchlevel. I fixed that in #8, but this could also easily adapted to this PR. Find the output of the update script in this branch.

@toy
Copy link
Copy Markdown
Contributor Author

toy commented Feb 18, 2022

Moin @nevesenin :) Good catch, then it was broken for long time

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants