Skip to content

#2321 - Fix private callback visibility#2325

Draft
Jeckerson wants to merge 14 commits intodevelopmentfrom
#2321-private-callback-visibility
Draft

#2321 - Fix private callback visibility#2325
Jeckerson wants to merge 14 commits intodevelopmentfrom
#2321-private-callback-visibility

Conversation

@Jeckerson
Copy link
Copy Markdown
Member

@Jeckerson Jeckerson commented Nov 12, 2021 •
edited
Loading

Hello!

  • Type: bug fix | new feature | code quality | documentation
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

Thanks

@Jeckerson Jeckerson changed the title #2321 - Fox private callback visibility #2321 - Fшx private callback visibility Nov 12, 2021
@Jeckerson Jeckerson changed the title #2321 - Fшx private callback visibility #2321 - Fix private callback visibility Nov 12, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 13, 2021 •
edited
Loading

Codecov Report

❌ Patch coverage is 18.42105% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.13%. Comparing base (fd6e5f1) to head (a5a6b18).
⚠️ Report is 659 commits behind head on development.

Additional details and impacted files 
@@               Coverage Diff                @@
##             development   #2325      +/-   ##
================================================
- Coverage           7.18%   7.13%   -0.05%     
+ Complexity          8639    8612      -27     
================================================
  Files                343     344       +1     
  Lines              21977   21939      -38     
================================================
- Hits                1578    1566      -12     
+ Misses             20399   20373      -26
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jeckerson Jeckerson added the bug label Nov 13, 2021
@Jeckerson Jeckerson self-assigned this Nov 13, 2021
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Jeckerson
Merge branch 'development' into #2321-private-callback-visibility
a5a6b18 
# Conflicts:
#	Library/CompilerFile.php
#	composer.lock
#	config/autoload.php
#	phpunit.xml.dist
#	tests/ext-bootstrap.php
#	zephir
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 26, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Jeckerson Jeckerson

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Jeckerson