Skip to content

[Hunvre] Remove riot damage from Hunvre's cities#86601

Open
BalthazarArgall wants to merge 3 commits intoCleverRaven:masterfrom
BalthazarArgall:pp_hunvre
Open

[Hunvre] Remove riot damage from Hunvre's cities#86601
BalthazarArgall wants to merge 3 commits intoCleverRaven:masterfrom
BalthazarArgall:pp_hunvre

Conversation

@BalthazarArgall
Copy link
Copy Markdown
Contributor

Summary

None

Purpose of change

The nature of the apocalypse in Hunvre isn't a slow burn with riots gradually ruining the place but more sudden, silent and peaceful hence why riot damage should be eliminated.

Describe the solution

Redefine the riot_damage pp generators as empty.

Describe alternatives you've considered

Eventually add some riot damage back but it should be way subtler than vanilla DDA to take some amount of panic into account.

Testing

Spawned, no more blood everywhere.

Additional context

Thanks @dobbry-vechur

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 20, 2026
@BalthazarArgall BalthazarArgall changed the title Remove riot damage from Hunvre's cities [Hunvre] Remove riot damage from Hunvre's cities Apr 20, 2026
@dobbry-vechur
Copy link
Copy Markdown
Contributor

(all_mods)=> (continued from above) ERROR : src/mapgen_post_process.cpp:150 [void pp_generator::check() const] pp_generator 'riot_damage' has no sub_generators
(all_mods)=> 13:33:23.534 ERROR : src/mapgen_post_process.cpp:150 [void pp_generator::check() const] pp_generator 'riot_damage_road' has no sub_generators

huh well we may need to relax that debugmsg, it's likely too strict.

workaround would be a noop entry like "sub_generators": [ { "type": "bash_damage", "attempts": 0, "chance": 0 } ], but better to just remove that error on sub_generators_.empty()

@BalthazarArgall
Copy link
Copy Markdown
Contributor Author

BalthazarArgall commented Apr 20, 2026

What is this about sub generators?

Alright testing with empty subgenerators, hope I don't have to also fill the sub generator array with empty fields Oh okay I reread your comment, I'm also filling those then, a bit stupid yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods Issues related to mods or modding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants