Skip to content

Fix lmoe bunker stairs misalignment and other minor issues#86971

Merged
Maleclypse merged 10 commits into
CleverRaven:masterfrom
BalthazarArgall:lmoe_stairs
May 12, 2026
Merged

Fix lmoe bunker stairs misalignment and other minor issues#86971
Maleclypse merged 10 commits into
CleverRaven:masterfrom
BalthazarArgall:lmoe_stairs

Conversation

@BalthazarArgall
Copy link
Copy Markdown
Contributor

Summary

None

Purpose of change

  1. The lmoe bunker stairs are misaligned
  2. Insane lmoe file organization, needless mapgen definitions duplicates

Describe the solution

  • Remove the old bunker exit mapgens, replace them with a much smaller mapgen nest, spawned at the surface from the bunker mapgen itself. To accomodate this I had to slightly modify one of the layouts and give the nests a precise rotation since some of the stairs were located very close to the map borders.
  • Remove all the map duplicates. It was an insane incomprehensible mess, I think the intent was to have looted/unlooted maps as well as populated (with monsters)/unpopulated maps but nowadays this can be easily and cleanly replicated with just one definition per layout. Technically I'm using a palette distribution to make 25% of the bunkers looted (using a null palette), and I'm using an overmap_terrain "spawns" field to spawn between 2 to 6 zombies in 50% of the bunkers.
  • The bunker exit roofs have also been mapgen nestified while keeping the possible solar panel spawns.
  • The special prepper quest bunker has had the same treatment but due to me being too dum I had to keep it it's own mapgen/overmap_terrain etc.
  • Clean up the bunker exit from the random hard placed trees and bushes, now it uses the regional terrain, no more spot of trees in the middle of a naked field.

Describe alternatives you've considered

  • Wasted a few hours trying to rework the prepper quest map thing so it could be any of the other layout but I couldn't do it.
  • Don't null the loot palettes, I'm not sure we care to represent looted bunkers and if we do maybe it should be a bit more elegant than simply nulling the loot there. If pp generators can be made to remove loot we may be able to do it through that system in the future.
  • Make each layout it's own mapgen id, this would require adding 3 more special definitions and I don't see why we would need to differentiate them at the moment.
  • Remove the now unused terrain definitions from the palettes. Unneeded, plus maybe some other map somewhere uses it.

Testing

Spawned plenty of bunkers, looks fine to me. Admittedly not a lot of testing on the prepper quest logic part specifically but it should work.

Additional context

Fixes #86842.

@github-actions github-actions Bot added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON labels May 11, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @thaelina

@github-actions github-actions Bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels May 11, 2026
@github-actions github-actions Bot added Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Aftershock Anything to do with the Aftershock mod Mods: Magiclysm Anything to do with the Magiclysm mod Mods: No Hope Relating to the mod No Hope Scenarios New Scenarios, balancing, bugs with scenarios labels May 11, 2026
@GuardianDll
Copy link
Copy Markdown
Member

Error: Mods-(~[slow] ~[.],starting_items)=> JSON contains circular dependency, this object is discarded

    "vision_levels": "unusual_structure",
    "travel_cost_type": "roof"
  },
   ▲▲▲
  {
    "type": "overmap_terrain",


Mods-(~[slow] ~[.],starting_items)=> 17:28:21.844 ERROR : src/flexbuffer_json.cpp:332 [void JsonObject::error_skipped_members(const std::vector<size_t> &) const] (json-error)
Error: Mods-(~[slow] ~[.],starting_items)=> Unread data.  Invalid or misplaced field name "copy-from" in JSON data

    "type": "overmap_terrain",
    "id": [ "last_mage_on_earth_shelter" ],
    "copy-from": "lmoe_under_empty"
               ▲▲▲
  },

@github-actions github-actions Bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 12, 2026
@Maleclypse Maleclypse merged commit 30a8c59 into CleverRaven:master May 12, 2026
27 of 28 checks passed
@LeSHi4
Copy link
Copy Markdown

LeSHi4 commented May 13, 2026

Greetings! I find little bug :)
Screenshot 2026-05-13 213155
Screenshot 2026-05-13 213208
Screenshot 2026-05-13 213618

@github-actions
Copy link
Copy Markdown
Contributor

Hi @LeSHi4, welcome to CleverRaven! We see that this is your first time commenting here. Check out how development works and be sure to follow the code of conduct! We hope to see you around!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Aftershock Anything to do with the Aftershock mod Mods: Magiclysm Anything to do with the Magiclysm mod Mods: No Hope Relating to the mod No Hope Scenarios New Scenarios, balancing, bugs with scenarios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LMOE shelter stairs arent aligned

4 participants