De-charge a bunch of stuff that should never have had charges#87000
Open
RenechCDDA wants to merge 1 commit into
Open
De-charge a bunch of stuff that should never have had charges#87000RenechCDDA wants to merge 1 commit into
RenechCDDA wants to merge 1 commit into
Conversation
Contributor
The charges should be migrated automatically and drop out as single items once you interact with it. |
Member
|
This comment was marked as abuse.
This comment was marked as abuse.
4bb92af to
8cebeb8
Compare
Member
|
@zephyrflow write your comments in good faith or don't write them at all, official warning. |
8cebeb8 to
a71c340
Compare
Contributor
|
The only thing that worries me about this is how it plays with tile item limits. Those already lead to a vast majority of the storage problems I find in game, and I feel like increasing the “item bulk” of items you already typically get in large quantities may exacerbate that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Death to charges
Describe the solution
Removed charges and fake ammo types from the following items:
Gravel
Soil
Sand
Quicklime
Niter
Black powder
Rocket Fuel
Bolas
Throwing Sticks
Nets
Describe alternatives you've considered
Death to charges
Testing
Game loads (vanilla)
I bet it won't load with mods, but we'll see if CI likes it
Additional context
Known "issues":Existing items of these type will no longer register their charges. e.g.Death to chargessoil (43)will becomesoil, "losing" 42 charges in the process. The charges will still be there, they will just be ignored by the system.