Skip to content

De-charge a bunch of stuff that should never have had charges#87000

Open
RenechCDDA wants to merge 1 commit into
CleverRaven:masterfrom
RenechCDDA:DEATH_TO_CHARGES_1
Open

De-charge a bunch of stuff that should never have had charges#87000
RenechCDDA wants to merge 1 commit into
CleverRaven:masterfrom
RenechCDDA:DEATH_TO_CHARGES_1

Conversation

@RenechCDDA
Copy link
Copy Markdown
Member

@RenechCDDA RenechCDDA commented May 13, 2026

Summary

None

Purpose of change

Death to charges

Describe the solution

Removed charges and fake ammo types from the following items:
Gravel
Soil
Sand
Quicklime
Niter
Black powder
Rocket Fuel
Bolas
Throwing Sticks
Nets

Describe alternatives you've considered

Death to charges

Testing

Game loads (vanilla)
I bet it won't load with mods, but we'll see if CI likes it

Additional context

Known "issues":
Existing items of these type will no longer register their charges. e.g. soil (43) will become soil, "losing" 42 charges in the process. The charges will still be there, they will just be ignored by the system. Death to charges

@github-actions github-actions Bot added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels May 13, 2026
@mqrause
Copy link
Copy Markdown
Contributor

mqrause commented May 13, 2026

Existing items of these type will no longer register their charges. e.g. soil (43) will become soil, "losing" 42 charges in the process. The charges will still be there, they will just be ignored by the system. Death to charges

The charges should be migrated automatically and drop out as single items once you interact with it.

@GuardianDll
Copy link
Copy Markdown
Member

../tests/throwing_test.cpp:326: FAILED:
  REQUIRE( thrown.charges > 1 )
with expansion:
Error:   0 > 1

@zephyrflow

This comment was marked as abuse.

@RenechCDDA RenechCDDA force-pushed the DEATH_TO_CHARGES_1 branch from 4bb92af to 8cebeb8 Compare May 13, 2026 11:37
@github-actions github-actions Bot added the Code: Tests Measurement, self-control, statistics, balancing. label May 13, 2026
@harakka
Copy link
Copy Markdown
Member

harakka commented May 13, 2026

@zephyrflow write your comments in good faith or don't write them at all, official warning.

@RenechCDDA RenechCDDA force-pushed the DEATH_TO_CHARGES_1 branch from 8cebeb8 to a71c340 Compare May 13, 2026 12:13
@Beatdotroot
Copy link
Copy Markdown
Contributor

The only thing that worries me about this is how it plays with tile item limits. Those already lead to a vast majority of the storage problems I find in game, and I feel like increasing the “item bulk” of items you already typically get in large quantities may exacerbate that.

@github-actions github-actions Bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants