tests: update expected Binary Ninja version to 5.3#3011
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
mr-tz
force-pushed
the
fix-binja-version-test
branch
from
f791240 to
df6df82
Compare
github-actions
Bot
dismissed
their stale review
CHANGELOG updated or no update needed, thanks! 😄
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Binary Ninja version check in the test suite from 5.2 to 5.3. The review feedback suggests using a minimum version check with tuple comparison instead of an exact equality check to make the test more robust against future version updates.
mr-tz
force-pushed
the
fix-binja-version-test
branch
from
df6df82 to
5eb9a0f
Compare
|
cc: @xusheng6 |
Looks good to me. This will free us from building the version every time we release a new stable binja |
|
Thanks! |
3 participants
Updates the expected Binary Ninja version in test_binja_version to 5.3. This fix addresses the test failure caused by the recent update of Binary Ninja to version 5.3 in the environment.