[VQueues] Major redesign of vqueues internal design#4573
Merged
AhmedSoliman merged 9 commits intomainfrom Apr 22, 2026
Merged
Conversation
This was referenced Apr 9, 2026
Closed
This was referenced Apr 13, 2026
Merged
AhmedSoliman
force-pushed
the
pr4573
branch
5 times, most recently
from
4412a0f to
41faee4
Compare
AhmedSoliman
force-pushed
the
pr4573
branch
2 times, most recently
from
dc156c7 to
a5d312f
Compare
AhmedSoliman
force-pushed
the
pr4573
branch
3 times, most recently
from
0c69b1b to
718105e
Compare
AhmedSoliman
force-pushed
the
pr4573
branch
2 times, most recently
from
edd9612 to
9b2d914
Compare
This was referenced Apr 21, 2026
Without this, we cannot read unmerged keys from partition-store
VQueueStatistics after transitions + separate pause and suspend
tillrohrmann
approved these changes
Apr 21, 2026
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks for this amazing piece of work @AhmedSoliman. As far as I can tell, the changes look great. 🤯 probably explains best my current state of mind as I am still processing the new state of the world. I might not have been able to trace all the different state transitions but I believe that you've already tested things well and if there are bugs left, then we iron them out while testing the new vqueue code paths. +1 for merging it!
Comment on lines
+450
to
+461
| // Left intentionally for future reference | ||
| // pub fn wake_up<T>( | ||
| // &mut self, | ||
| // at: UniqueTimestamp, | ||
| // header: &impl EntryStatusHeader, | ||
| // run_at: Option<RoughTimestamp>, | ||
| // updated_state: &T, | ||
| // ) where | ||
| // T: EntryStatusExtra + bilrost::Message + bilrost::encoding::RawMessage, | ||
| // (): bilrost::encoding::EmptyState<(), T>, | ||
| // { | ||
| // } |
Contributor
There was a problem hiding this comment.
What is the reference for? Modulo the generic update_state it looks pretty similar (signature wise) to the current wake_up implementation.
Contributor
Author
There was a problem hiding this comment.
Primarily for the generic and how this can be used for polymorphic extra state type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.