restate-doctor uses the correct merge operator for partition-store#4619
restate-doctor uses the correct merge operator for partition-store#4619AhmedSoliman merged 6 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b24a723ae5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| else { | ||
| error!("State mutation request was ignored because the vqueue {qid} does not exist!"); | ||
| // todo: When/if we made state mutations rpc-like, we should return the error to the | ||
| // user here. | ||
| return Ok(()); |
There was a problem hiding this comment.
When experimental_enable_vqueues is on, handle_external_state_mutation always routes PatchState through vqueue_enqueue_state_mutation, but this branch now calls VQueue::get(...).await? and returns Ok(()) if the queue is missing. That silently drops the mutation (only logs), which can happen for the first mutation on an idle key or after the queue became dormant. In those cases user state updates are lost instead of being queued/applied.
Useful? React with 👍 / 👎.
Without this, we cannot read unmerged keys from partition-store
1 participant
Without this, we cannot read unmerged keys from partition-store
Stack created with Sapling. Best reviewed with ReviewStack.