Skip to content

fix: Omit RequestedFrameworks telemetry property when empty#506

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-requested-frameworks-property
Draft

fix: Omit RequestedFrameworks telemetry property when empty#506
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-requested-frameworks-property

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 27, 2026

The check-start telemetry event was sending RequestedFrameworks="" when no --tfm options were specified, resulting in noisy/unusable data.

Changes

  • Conditionally include RequestedFrameworks property only when frameworks are present after filtering
  • When null/empty input or no frameworks match the regex pattern, omit property entirely from telemetry event
// Before: always sent property, even with empty string
_telemetry.TrackEvent("check-start", [("RequestedFrameworks", frameworks)], []);

// After: omit property when no frameworks to report
var properties = string.IsNullOrEmpty(frameworks)
    ? new (string, string)[] { }
    : new (string, string)[] { ("RequestedFrameworks", frameworks) };
_telemetry.TrackEvent("check-start", properties, []);

Framework filtering logic (regex, sorting, truncation) remains unchanged.

Original prompt

This section details on the original issue you should resolve

<issue_title>[Analytics] RequestedFrameworks property not returning values in uno-check/check-start event</issue_title>
<issue_description>### Current behavior 🐛

RequestedFrameworks property not returning values in uno-check/check-start event

Expected behavior 🎯

Image

</issue_description>

Comments on the Issue (you are @copilot in this section)

@Jen-Uno https://github.com/unoplatform/private/blob/master/Telemetry-Docs/Telemetry.md
  • Fixes unoplatform/uno-private#1498

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…pecified

Co-authored-by: Jen-Uno <214558326+Jen-Uno@users.noreply.github.com>
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI changed the title [WIP] Fix RequestedFrameworks property not returning values fix: Omit RequestedFrameworks telemetry property when empty Jan 27, 2026
Copilot AI requested a review from Jen-Uno January 27, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants