Skip to content

fix: Omit RequestedFrameworks telemetry property when empty #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: Omit RequestedFrameworks telemetry property when empty #506

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
484c51c
Initial plan
Copilot Jan 27, 2026
a667ce2
fix: Only send RequestedFrameworks in telemetry when frameworks are s…
Copilot Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions UnoCheck/Telemetry/TelemetryClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,14 @@ public static void TrackStartCheck(string[] requestedFrameworks)
.Select(s => s[..32])
.Take(10) ?? []);

// Only include RequestedFrameworks property if there are actual frameworks to report
var properties = string.IsNullOrEmpty(frameworks)
? new (string, string)[] { }
: new (string, string)[] { ("RequestedFrameworks", frameworks) };

_telemetry.TrackEvent(
"check-start",
[
("RequestedFrameworks", frameworks),
],
properties,
[]
);
}
Expand Down
Loading