Skip to content
This repository was archived by the owner on May 20, 2022. It is now read-only.

Changes by create-pull-request action#7

Open
github-actions[bot] wants to merge 1 commit into
masterfrom
create-pull-request/patch
Open

Changes by create-pull-request action#7
github-actions[bot] wants to merge 1 commit into
masterfrom
create-pull-request/patch

Conversation

@github-actions
Copy link
Copy Markdown

Automated changes by create-pull-request GitHub action

@github-actions github-actions Bot force-pushed the create-pull-request/patch branch from 3119251 to af9d9b1 Compare December 27, 2021 08:03
@nevesenin
Copy link
Copy Markdown

Hi! Can you merge this, please?

@skaes
Copy link
Copy Markdown
Contributor

skaes commented Jan 12, 2022

Will not work for ruby 3.1.0, as you cannot simply apply all patches, only the ones listed in https://github.com/skaes/rvm-patchsets/blob/master/patchsets/ruby/3.1.0/railsexpress

@skaes skaes requested review from skaes and removed request for skaes January 12, 2022 13:38
@nevesenin
Copy link
Copy Markdown

Ah, ok. Didn't see that. Thanks.

@toy
Copy link
Copy Markdown
Contributor

toy commented Jan 12, 2022

@skaes My assumption was that patches/ruby/3.1.0/railsexpress would contain same patches as patchsets/ruby/3.1.0/railsexpress

@skaes
Copy link
Copy Markdown
Contributor

skaes commented Jan 13, 2022

@skaes My assumption was that patches/ruby/3.1.0/railsexpress would contain same patches as patchsets/ruby/3.1.0/railsexpress

that is usually correct, but sometimes the patch list changes, for example when I find out one of the patches has become obsolete. Then I have to keep the old patch set and the new patch set araound, so that rvm installs with the old patch set won't fail.

@toy toy mentioned this pull request Jan 13, 2022
@github-actions github-actions Bot force-pushed the create-pull-request/patch branch from af9d9b1 to d61de14 Compare March 15, 2022 08:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants